Add GitHub Actions to compile all hardware combinations #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- comment out all #define macros related to batteries and inverters in USER_SETTINGS.h - remove workflow to compile arduino sketch, as the sketch does not compile without defining the #define macros - add workflow to compile all batteries in combination with the inverter communication protocol: BYD_MODBUS - add workflow to compile all inverter communication protocols in combination with the battery: NISSAN_LEAF_BATTERY - add workflow to compile all combinations of batteries and inverter communication protocols. This workflow can be triggered manually.
lenvm
changed the title
dalathegreat
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request implements automated compilation of the Arduino sketch for all hardware targets.
It does this by adding separate GitHub Actions to compile for all batteries, for all inverters, and for the combination of all batteries and inverters.
How
This pull request adds:
BYD_MODBUS. This action is performed on each push/pull request. It currently runs 7 jobs.NISSAN_LEAF_BATTERY. This action is performed on each push/pull request. It currently runs 7 jobs.In order to achieve this, this pull request:
USER_SETTINGS.h.Why
It is extremely useful to continuously check if the code compiles for all hardwares that the code intends to support.